Milter-greylist

Lawren Quigley-Jones <lawrenqj@...> wrote:

> key length check is now gone...

Lasts bits before I include your code:
1) style. I'm not a style maniac, but mixing different styles makes the
code less readable. Here are a few rules in milter-greylist sources:
- no lines longer thant 80 chars
- multiline comments are like this:
/*
 * foo bar buz
 * foo bar buz
 */
- K&R style function declarations with the function name at the
beginning of a line (helpful for grep ^function_name)
int 
popIPCheck(ipAddr)
char *ipAddr 
{

2) command line options: [-b popipdb]
There are already too may options. Could you add a config file directive
instead? If you can't I'll do it?

3) Documentation
We need documentation for the new feature. Of course the documentation
differs if we add a config line option instead of a command line flag...

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@...