Milter-greylist

Hi,

>>>>> On Sun, 8 Jan 2006 13:12:22 +0000
>>>>> Lawren Quigley-Jones <lawrenqj@...> said:

lawrenqj>     I couldn't find anything in the poprelayd documentation about ipv6, but
lawrenqj>     there didn't seem to be anything in the perl code that would prohibit it. 
lawrenqj>     I don't see the harm in asking the db for ipv6 values regardless.

Yes, perhaps it is not vulnerability issue.  But, your previous code
didn't do right thing against an IPv6 address, and issued wrong
warning message.

lawrenqj>     I'm not that familiar with ipv6.  I gathered from a quick google search
lawrenqj>     that the max string length is 240, so I set my keylenth check to 255.  is
lawrenqj>     this safe?

The max. length of an IPv6 address is 46 bytes (including trailing \0)
without regarding of a string form of a scope-id.

In anyway, while you think to need just checking a length of an IP
address without regarding an address family, the following check is
useless, and it should be go away, IMHO.

	if ( key.size > 255 )
	{
		syslog(LOG_DEBUG, "The IP requested for was %d character long...  Possible stack attack!!!", key.size);
		key.size = 255;
	}

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/