Hi,
I found that we didn't copy helo string for SPF2. There is a patch.
It may better to always copy helo string regardless of HAVE_SPF*
definition to avoid such mistake.
Index: milter-greylist.c
diff -u -p milter-greylist.c.orig milter-greylist.c
--- milter-greylist.c.orig Mon Nov 28 16:00:36 2005
+++ milter-greylist.c Tue Nov 29 15:22:49 2005
@@ -166,7 +166,8 @@ mlfi_helo(ctx, helostr)
priv = (struct mlfi_priv *) smfi_getpriv(ctx);
-#if (defined(HAVE_SPF) || defined(HAVE_SPF_ALT))
+#if defined(HAVE_SPF) || defined(HAVE_SPF_ALT) || defined(HAVE_SPF2_10) || \
+ defined(HAVE_SPF2)
strncpy_rmsp(priv->priv_helo, helostr, ADDRLEN);
priv->priv_helo[ADDRLEN] = '\0';
#endif
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@... ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/Message
missing copy of helo for SPF2
2005-11-29 by Hajimu UMEMOTO
Attachments
- No local attachments were found for this message.