Milter-greylist

> > I have switched from version 1.6 to 2.0rc3 on my production
> > mail server, and noticed a serious misbehaviour in the handling
> > of "acl whitelist domain" statements.
> 
> I wrote a quick fix for that problem, but I have no time to test it. Can
> you give me your feedback?
> http://hcpnet.free.fr/milter-greylist/domaincmp.diff 
> 
> (in a nutshell, I used the older emailcmp function for domain
> comparison.

In the meantime I had produced a similar fix, also using a new
domaincmp() function, but written from scratch. I'll attach the
patch.

I'm running with my patch in production now, it works fine.

There's one functional difference between our two implementations
of domaincmp() - yours matches any hostname that contains domain
anywhere (/^.*domain.*$/), mine matches from the end to the beginning
(/^.*domain$). I would much prefer the behaviour of my function -
a hostname "worldnet.att.com" would match a domain "net.at" with
your function, which is terribly confusing IMHO. I'd leave substring
matching to regexps. I hope you agree.

mp.