Milter-greylist

Hi,

I have switched from version 1.6 to 2.0rc3 on my production
mail server, and noticed a serious misbehaviour in the handling
of "acl whitelist domain" statements.

Having this in greylist.conf:

  acl whitelist domain example.net

will only whitelist when the hostname is exactly "example.net",
"host.example.net" will be denied. This is not how it's documented,
and in 1.6 it worked as advertised.

I think the culprit is emailcmp() in acl.c - it doesn't match
substrings, only completely equal strings. Do we need a new
domaincmp() function, which would compare hostname to domain
by starting from the end of both strings working backwards,
and returning success when the beginning of domain has been
reached without any differing characters?

A workaround would be to use a regexp:

  acl whitelist domain /.*\.example\.net$/
  
I think this should be fixed before 2.0 final.

mp.