Milter-greylist

At 11:06 AM 5/21/05, manu@... wrote:
>Brian W. Antoine <briana@...> wrote:
>
>>    Ok, I've tracked the problem to the emailcmp() routine in acl.c, which
>> somebody modified to strip leading and trailing characters from recently.
>> The problem is, they strip them from the real strings, not temporary copies
>> that are then used for the comparison, and while they simply step over the
>> leading characters they don't want, they actually truncate the string to
>> get rid of the extras.
>> 
>>    Stripping leading and trailing whitespace is probably OK, but I think the
>> < and > should be left in place.  Opinions?
>
>My idea was to copy the string before touching it. Would it be alright?

  That would solve it also, though at the expense of copying the data around
a couple of more times.  Those printf's that are still in there are probably
responsible for more wasted cycles than the data copy would be.

  I just ifdef'd out the whole stripping section so that the routine resembles
the b2 version's behavior, for the moment at least.  I can understand the
logic behind removing the whitespace, make sure the strings stand the best
chance of testing similar data, I'd have left it at that though and not
touched the <> characters.