Milter-greylist

Emanuel,

--- In milter-greylist@yahoogroups.com, Emmanuel Dreyfus <manu@n...>
wrote:
> Enjoy:
> 
> http://ftp.espci.fr/pub/milter-greylist/milter-greylist-2.0b4.tgz
> MD5 (milter-greylist-2.0b4.tgz) = a89b89a5dfd1a229ecde163c4c0e597c
> 
> Only one change from 2.0beta3:
> 2.0b4:
>         Fix MX sync bug on Solaris, shut up warnings at build time
> 

When you said that you have commited the changes, I thought that you
have also submitted the part that relates to the swap of the checks
for __EXTENSIONS__ and _REENTRANT. Without it (as it is now in 2.0b4)
the configure gives the following:

...
checking if -D__EXTENSIONS__ is needed to use snprintf... yes
checking if -D_REENTRANT is needed to use localtime_r... no
...

Whereas it should say (with the below patch enabled):

...
checking if -D_REENTRANT is needed to use localtime_r... yes
checking if -D__EXTENSIONS__ is needed to use snprintf... yes
...

Here is the patch that fixes the problem:

---CUT---
--- configure.ac-orig   2005-03-29 17:36:54.000000000 +0300
+++ configure.ac        2005-03-29 19:22:04.885469000 +0300
@@ -246,6 +246,28 @@
            [], [<time.h> defines timeradd]) timeradd=no])
 AC_MSG_RESULT([$timeradd])

+# Check if -D_REENTRANT is needed for localtime_r, gmtime_r
+SAVEDCFLAGS=$CFLAGS
+CFLAGS=$CFLAGS" -ansi -Wall -Werror"
+AC_MSG_CHECKING([if -D_REENTRANT is needed to use localtime_r])
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
+               #include <time.h>
+       ],[[
+
+               (void)localtime_r(NULL, NULL);
+       ]])], [dreentrant=no],
+               [AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
+                               #define _REENTRANT
+                               #include <time.h>
+                       ],[[
+                                (void)localtime_r(NULL, NULL);
+                       ]])],
+                       [SAVEDCFLAGS=$SAVEDCFLAGS" -D_REENTRANT";
+                        dreentrant=yes], [dreentrant=no])
+       ])
+AC_MSG_RESULT([$dreentrant])
+CFLAGS=$SAVEDCFLAGS
+
 # Check if -D__EXTENSIONS__ is needed for snprintf, getopt, seteuid...
 SAVEDCFLAGS=$CFLAGS
 CFLAGS=$CFLAGS" -ansi -Wall -Werror"
@@ -271,28 +293,6 @@
 AC_MSG_RESULT([$dextensions])
 CFLAGS=$SAVEDCFLAGS

-# Check if -D_REENTRANT is needed for localtime_r, gmtime_r
-SAVEDCFLAGS=$CFLAGS
-CFLAGS=$CFLAGS" -ansi -Wall -Werror"
-AC_MSG_CHECKING([if -D_REENTRANT is needed to use localtime_r])
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
-               #include <time.h>
-       ],[[
-
-               (void)localtime(NULL);
-       ]])], [dreentrant=no],
-               [AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
-                               #define _REENTRANT
-                               #include <stdio.h>
-                       ],[[
-                                (void)localtime(NULL);
-                       ]])],
-                       [SAVEDCFLAGS=$SAVEDCFLAGS" -D_REENTRANT";
-                        dreentrant=yes], [dreentrant=no])
-       ])
-AC_MSG_RESULT([$dreentrant])
-CFLAGS=$SAVEDCFLAGS
-
 # Check for libpthread. On FreeBSD, the libc_r does the job.
 # On digitalUNIX, libpthreads (with a trailing s) is the library to use
 AC_CHECK_LIB([pthread], [pthread_create],
---CUT---

I appologize if I have created the confusion.

Best regards,

Ranko