Yahoo Groups archive

Milter-greylist

Index last updated: 2026-04-28 23:32 UTC

Message

Re: [milter-greylist] configure.ac _REENTRANT issue (was: sync.c:local_addr() use)

2005-03-27 by Hajimu UMEMOTO

Hi,

>>>>> On Sat, 26 Mar 2005 23:18:12 +0200
>>>>> Ranko Zivojnovic <ranko@...> said:

ranko> On Sat, 2005-03-26 at 21:15 +0100, manu@... wrote:
> ranko_z <ranko@...> wrote:
> 
> > *** 210,219 ****
> >   fi
> >   if test $ipv6_cv_$1 = yes; then
> >     AC_DEFINE_UNQUOTED($ac_tr_lib)
> > -   ifelse([$2], , :, [$2])
> >   else
> >     ifelse([$3], , :, [$3])
> >   fi])
> > 
> >   IPv6_CHECK_FUNC(getaddrinfo,
> >       AC_DEFINE([HAVE_GETADDRINFO], [],
> > --- 210,219 ----
> >   fi
> >   if test $ipv6_cv_$1 = yes; then
> >     AC_DEFINE_UNQUOTED($ac_tr_lib)
> >   else
> >     ifelse([$3], , :, [$3])
> >   fi])
> > + #  ifelse([$2], , :, [$2])
> > 
> >   IPv6_CHECK_FUNC(getaddrinfo,
> >       AC_DEFINE([HAVE_GETADDRINFO], [],
> 
> What does this change do?

ranko> If you execute configure as it was you will notice in config.log that
ranko> HAVE_GETADDRINFO and HAVE_GETNAMEINFO do get declared twice in
ranko> confdefs.h as follows:
ranko> #define HAVE_GETADDRINFO
ranko> #define HAVE_GETADDRINFO 1
ranko> #define HAVE_GETNAMEINFO
ranko> #define HAVE_GETNAMEINFO 1

Your patch simply ignores the action.  The following change should be
better, IMHO:

Index: configure.ac
diff -u configure.ac.orig configure.ac
--- configure.ac.orig	Sat Mar 19 16:41:09 2005
+++ configure.ac	Sun Mar 27 21:02:28 2005
@@ -152,10 +152,6 @@
 
 # Check for getaddrinfo and getnameinfo
 AC_DEFUN([IPv6_CHECK_FUNC], [
-changequote(, )dnl
-ac_tr_lib=HAVE_`echo $1 | sed -e 's/[^a-zA-Z0-9_]/_/g' \
-  -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/'`
-changequote([, ])dnl
 AC_CHECK_FUNC($1, [dnl
   ac_cv_lib_socket_$1=no
   ac_cv_lib_inet6_$1=no
@@ -209,17 +205,16 @@
   fi
 fi
 if test $ipv6_cv_$1 = yes; then
-  AC_DEFINE_UNQUOTED($ac_tr_lib)
   ifelse([$2], , :, [$2])
 else
   ifelse([$3], , :, [$3])
 fi])
 
 IPv6_CHECK_FUNC(getaddrinfo, 
-    AC_DEFINE([HAVE_GETADDRINFO], [], 
+    AC_DEFINE([HAVE_GETADDRINFO], [1], 
     [Define to 1 if you have the `getaddrinfo' function.]))
 IPv6_CHECK_FUNC(getnameinfo, 
-    AC_DEFINE([HAVE_GETNAMEINFO], [], 
+    AC_DEFINE([HAVE_GETNAMEINFO], [1], 
     [Define to 1 if you have the `getnameinfo' function.]))
 
 # Check if <syslog.h> defines LOG_PERROR

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@...  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/

Attachments

Move to quarantaine

This moves the raw source file on disk only. The archive index is not changed automatically, so you still need to run a manual refresh afterward.